Jon,

What I could do is not distribute the "setenv.sh" file and, instead, check
for the existence of this file. If it exists (which would only occur if the
user has created the file), then catalina.sh and tools-wrapper.sh would
source it.

I think that would comply with your requirement. Also, should we put the
setenv.sh somewhere else as well.

If the above sounds OK, I can cvs remove the setenv.sh file and make the
sourcing conditional.

Thanks,

Patrick

Jon Stevens wrote:
> 
> on 11/27/01 2:34 PM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:
> 
> > Index: setenv.sh
> > ===================================================================
> > #!/bin/sh
> > #
> > -----------------------------------------------------------------------------
> > # setenv.sh - File to hold all user customizable environment variables
> > #
> > # $Id: setenv.sh,v 1.1 2001/11/27 22:34:25 patrickl Exp $
> > #
> > -----------------------------------------------------------------------------
> >
> > # To permanently set your JAVA_HOME environment variable, uncomment and
> > # customize the following line with the absolute path to your JAVA_HOME
> > # JAVA_HOME=/usr/java
> 
> -1
> 
> I don't think that this file should exist in CVS if it is a user file.
> 
> The problem being that if a user upgrades to a new version of Catalina, then
> they will risk overwriting this file.
> 
> Instead, it should be documented that the file needs to be created in order
> to be used.
> 
> -jon
> 
> --
> To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

-- 
_____________________________________________________________________
Patrick Luby                          Email: [EMAIL PROTECTED]
Sun Microsystems                              Phone: 408-276-7471
901 San Antonio Road, USCA14-303
Palo Alto, CA 94303-4900
_____________________________________________________________________

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to