I can't get code involving index and length right without a lot of trial and error. Fortunately the internal test revealed this one.
Larry > -----Original Message----- > From: Bill Barker [mailto:[EMAIL PROTECTED]] > Sent: Wednesday, December 19, 2001 1:09 AM > To: Tomcat Developers List > Subject: Re: cvs commit: > jakarta-tomcat/src/share/org/apache/tomcat/util > JavaGeneratorTool.java > > > Oh, well, I guess I had to screw up eventually :-( > > Thanks for cleaning up my mess. > ----- Original Message ----- > From: <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Tuesday, December 18, 2001 6:39 PM > Subject: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util > JavaGeneratorTool.java > > > > larryi 01/12/18 18:39:39 > > > > Modified: src/share/org/apache/tomcat/util > JavaGeneratorTool.java > > Log: > > Fix IndexOutOfBoundsException > > > > Revision Changes Path > > 1.5 +1 -1 > jakarta-tomcat/src/share/org/apache/tomcat/util/JavaGeneratorTool.java > > > > Index: JavaGeneratorTool.java > > > =================================================================== > > RCS file: > /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/Java > GeneratorTool. > java,v > > retrieving revision 1.4 > > retrieving revision 1.5 > > diff -u -r1.4 -r1.5 > > --- JavaGeneratorTool.java 2001/12/14 03:55:11 1.4 > > +++ JavaGeneratorTool.java 2001/12/19 02:39:39 1.5 > > @@ -78,7 +78,7 @@ > > continue; > > } > > > > - if( (s.length()>=endIdx) && s.charAt( endIdx ) != '/' ) { > > + if( (s.length()>endIdx) && s.charAt( endIdx ) != '/' ) { > > index = s.indexOf(keywords[i],index+3); > > continue; > > } > > > > > > > > > > -- > > To unsubscribe, e-mail: > <mailto:[EMAIL PROTECTED]> > > For additional commands, e-mail: > <mailto:[EMAIL PROTECTED]> > > > > > -- > To unsubscribe, e-mail: > <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: > <mailto:[EMAIL PROTECTED]> > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
