Paul Speed wrote:
> 
> >   +                 return "java.net.URLEncoder.encode(\"\" + " + v + ")";
> 
> I know I'm being pedantic, but it's a small pet peeve of mine. :)
> How about:
>       return "java.net.URLEncoder.encode( String.valueOf(v) )";

So much for attention to details...  
return "java.net.URLEncoder.encode( String.valueOf(" + v + ") )";

-Paul

> 
> Should do the same thing without all the behind-the-scenes
> StringBuffer stuff.
> 
> -Paul Speed
> 
> [EMAIL PROTECTED] wrote:
> >
> > remm        2002/09/05 04:27:20
> >
> >   Modified:    jasper2/src/share/org/apache/jasper/compiler Generator.java
> >   Log:
> >   - Force the convesion of the value to a string.
> >   - Note: I am not convinced this is a compliance issue (and it looks like bad 
>design
> >     to pass an object or null); this just reverts back the old behavior.
> >
> >   Revision  Changes    Path
> >   1.90      +4 -4      
>jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
> >
> >   Index: Generator.java
> >   ===================================================================
> >   RCS file: 
>/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
> >   retrieving revision 1.89
> >   retrieving revision 1.90
> >   diff -u -r1.89 -r1.90
> >   --- Generator.java    4 Sep 2002 23:45:29 -0000       1.89
> >   +++ Generator.java    5 Sep 2002 11:27:19 -0000       1.90
> >   @@ -749,7 +749,7 @@
> >                         "_jspx_fnmap" );
> >                 }
> >                 if (encode) {
> >   -                 return "java.net.URLEncoder.encode(" + v + ")";
> >   +                 return "java.net.URLEncoder.encode(\"\" + " + v + ")";
> >                 }
> >                 return v;
> >                } else if( attr.isNamedAttribute() ) {
> >
> >
> >
> >
> > --
> > To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
> 
> --
> To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to