I agree that my patch is buggy in the case of a request coming from 80 or 443, but if we want to support port bases V hosting, we need to pass it down, if not
[uri:www.something.com:8080/somecontext] Definitely will not work (this not works now i.e).. so to pass the port as part of the hostname is needed when port is different from 80 and 443.. FOr the other 2 the is_virtual and the changes inside the mapper.. The initial idea was to do what isapi_redirector from jk does right now, in jk i_r.dll there are 2 types of mappings: 1) globals ( for all VS and Default ) and 2) particular ( for a concrete VS or Default ) This needs to do 2 passes for the mapper, one for the particular mappings with host+port ( if not 80 or 443 ) as vhost, and if none found other for the Global mappings with NULL as vhost.. that is what isapi does.. For the mapper, i was trying to need only one pass in the mapper, but after looking at the code, it was buggy, as VS request from a registered vhost, never will be mapped to anything outside of that vhost, so it's need to do the two passes.. So my grandtotal for my first commits after months is 2 bugs in 2 commits, nice startup, thanks Mladen.. ;) Saludos , Ignacio J. Ortega > -----Mensaje original----- > De: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > Enviado el: 22 de septiembre de 2002 11:36 > Para: [EMAIL PROTECTED] > Asunto: cvs commit: > jakarta-tomcat-connectors/jk/native2/server/apache2 > mod_jk2.c > > > mturk 2002/09/22 02:35:46 > > Modified: jk/native2/server/apache2 mod_jk2.c > Log: > Cannot use the hostname:server_port cause the port is 0 for all > host:80 requests. Also is_virtual is used for separating default and > virtual hosts. In case of default server host the hostname provided > to uriMap _MUST_ be NULL to be able to map the default uri:/ > > Revision Changes Path > 1.52 +2 -2 > jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk2.c > > Index: mod_jk2.c > =================================================================== > RCS file: > /home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache2/ > mod_jk2.c,v > retrieving revision 1.51 > retrieving revision 1.52 > diff -u -r1.51 -r1.52 > --- mod_jk2.c 22 Sep 2002 02:50:42 -0000 1.51 > +++ mod_jk2.c 22 Sep 2002 09:35:46 -0000 1.52 > @@ -679,7 +679,7 @@ > */ > > uriEnv = workerEnv->uriMap->mapUri(env, workerEnv->uriMap, > - > apr_psprintf(r->pool,"%s:%d",r->hostname,r->server->port), > + r->server->is_virtual ? r->hostname : NULL, > r->uri ); > > if( uriEnv== NULL || uriEnv->workerName == NULL) { > > > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
