Henri Gomez wrote:
> I'm fine with the makefile updates but there is a problem with change in
> apache-1.3/mod_jk.c since there is no ap_server_strip_chroot call
> available on my Linux box.
>
> Is it an OpenBSD specific call ?
>

Yes. My bad here. I mistakenly assumed that the chroot feature in OpenBSD's
Apache was not specific to OpenBSD. I thought they just changed the default
setting of an existing feature.

> If so we'll have to add some #ifdef OPEN_BSD and I'd like to
> have others jk commiters opinion. (I allready put too much
> #ifdef AS400 ;)
>
> I'll be to use a #ifdef CHROOTED_APACHE :
>

FWIW, I like the feature based define. If other OS's or Apache incorporate
OpenBSD's chroot option, then it wouldn't need to be changed. On the other
hand, if the consensus is not to commit the patch into mod_jk to keep the
cruft down, the OpenBSD port can apply the patch (assuming my port is
committed).

> @@ -1742,7 +1746,7 @@ static void jk_init(server_rec *s, ap_po
>       /* Open up log file */
>       if(conf->log_file && conf->log_level >= 0) {
>           if(!jk_open_file_logger(&(conf->log), conf->log_file,
> conf->log_level)) {
> #ifdef CHROOTED_APACHE
>              conf->log = main_log;
> #else
>               conf->log = NULL;
> #endif
>           } else {
>               main_log = conf->log;
>           }

I'm thinking the jk_init change is not OpenBSD chroot specific. If someone
configures Apache's ServerType as standalone combined with the User/Group
directives, I think the problem I described with the log file would occur.
Isn't the conf->log = main_log behavior more generally more desirable?

Regards,
-Kurt


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to