remm        2003/07/26 07:55:27

  Modified:    catalina/src/share/org/apache/catalina/valves
                        AccessLogValve.java
  Log:
  - Remove useless casts.
  
  Revision  Changes    Path
  1.6       +6 -15     
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java
  
  Index: AccessLogValve.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- AccessLogValve.java       19 Jul 2003 13:16:25 -0000      1.5
  +++ AccessLogValve.java       26 Jul 2003 14:55:27 -0000      1.6
  @@ -593,9 +593,7 @@
               String value = null;
   
               ServletRequest req = request.getRequest();
  -            HttpServletRequest hreq = null;
  -            if (req instanceof HttpServletRequest)
  -                hreq = (HttpServletRequest) req;
  +            HttpServletRequest hreq = (HttpServletRequest) req;
   
               if (isResolveHosts())
                   result.append(req.getRemoteHost());
  @@ -604,8 +602,7 @@
   
               result.append(" - ");
   
  -            if (hreq != null)
  -                value = hreq.getRemoteUser();
  +            value = hreq.getRemoteUser();
               if (value == null)
                   result.append("- ");
               else {
  @@ -838,13 +835,9 @@
           String value = null;
   
           ServletRequest req = request.getRequest();
  -        HttpServletRequest hreq = null;
  -        if (req instanceof HttpServletRequest)
  -            hreq = (HttpServletRequest) req;
  +        HttpServletRequest hreq = (HttpServletRequest) req;
           ServletResponse res = response.getResponse();
  -        HttpServletResponse hres = null;
  -        if (res instanceof HttpServletResponse)
  -            hres = (HttpServletResponse) res;
  +        HttpServletResponse hres = (HttpServletResponse) res;
   
           if (pattern == 'a') {
               value = req.getRemoteAddr();
  @@ -967,9 +960,7 @@
           Object value = null;
   
           ServletRequest req = request.getRequest();
  -        HttpServletRequest hreq = null;
  -        if (req instanceof HttpServletRequest)
  -            hreq = (HttpServletRequest) req;
  +        HttpServletRequest hreq = (HttpServletRequest) req;
   
           switch (type) {
               case 'i':
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to