Re: cvs commit: jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/managerHTMLManagerServlet.java LocalStrings.properties ManagerServlet.java

[Radim Kubacki]

[EMAIL PROTECTED] wrote:
remm        2003/06/15 11:31:45

  Modified:    webapps/manager/WEB-INF/classes/org/apache/catalina/manager
                        HTMLManagerServlet.java LocalStrings.properties
                        ManagerServlet.java
  Log:
  - Update the manager to implement the new functionality as described in the docs.
  - Pausing won't be implemented, due to difficulties, and the likelihood of bringing
    the whole server to its knees (thanks to Glenn for poiting that out).
  - Versioning is not tested yet.
  - Known issue: locking occurs on an uploaded WAR, for reasons which
    elude me right now.
  - Known issue 2: to deploy local WARs, a jar:file: URL must be used.
  
  1.2       +257 -55   jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/ManagerServlet.java
  
  Index: ManagerServlet.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/ManagerServlet.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- ManagerServlet.java	26 Mar 2003 09:49:19 -0000	1.1
  +++ ManagerServlet.java	15 Jun 2003 18:31:45 -0000	1.2
  @@ -331,6 +349,12 @@
           String path = request.getParameter("path");
           String type = request.getParameter("type");
           String war = request.getParameter("war");
  +        String tag = request.getParameter("tag");
  +        boolean update = false;
  +        if ((request.getParameter("update") != null) 
  +            && (request.getParameter("update").equals("true"))) {
  +            update = false;
  +        }
   
           // Prepare our output writer to generate the response message
           Locale locale = Locale.getDefault();
Remy,

here you set update to false or to false ;-). Would it be better touse 
something like this?

boolean update = "true".equals(request.getParameter("update"));

  @@ -399,6 +431,12 @@
           if (command == null)
               command = request.getServletPath();
           String path = request.getParameter("path");
  +        String tag = request.getParameter("tag");
  +        boolean update = false;
  +        if ((request.getParameter("update") != null) 
  +            && (request.getParameter("update").equals("true"))) {
  +            update = false;
  +        }
   
           // Prepare our output writer to generate the response message
           response.setContentType("text/plain");
The same here.

Radim

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]