----- Original Message -----
From: "Stefan Bodewig" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Friday, September 12, 2003 12:58 AM
Subject: Re: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net
PoolTcpEndpoint.java
> On 12 Sep 2003, <[EMAIL PROTECTED]> wrote:
>
> > +++ PoolTcpEndpoint.java 12 Sep 2003 03:51:36 -0000 1.16
> > @@ -389,12 +389,12 @@
> > if (accepted != null) {
> > try {
> > accepted.close();
> > - accepted = null;
> > } catch(Exception ex) {
> > msg = sm.getString("endpoint.err.nonfatal",
> > accepted, ex);
> > log.warn(msg, ex);
> > }
> > + accepted = null;
> > }
> >
> > if( ! running ) return null;
>
> wouldn't it be better to put the "accepted = null" into a finally
> block so you clean up even in the (unlikely but possible) case where
> close throws an Error (or Throwable) instead of an Exception?
>
Wouldn't do anything. The 'accepted' variable is local to the stack-frame,
so it goes away if I throw clear of the method. In this case you just get a
DoS condition where no threads are listening on the ServerSocket. I briefly
thought about changing the catch to 'Throwable', but is it really possible
for Socket.close to throw anything other than an Exception?
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
This message is intended only for the use of the person(s) listed above as the
intended recipient(s), and may contain information that is PRIVILEGED and
CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or
distribute this message or any attachment. If you received this communication in
error, please notify us immediately by e-mail and then delete all copies of this
message and any attachments.
In addition you should be aware that ordinary (unencrypted) e-mail sent through the
Internet is not secure. Do not send confidential or sensitive information, such as
social security numbers, account numbers, personal identification numbers and
passwords, to us via ordinary (unencrypted) e-mail.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
