Sorry. The Patch didn't attach. Here it is:
Index: tomcat.nsi
===================================================================
RCS file: /home/cvspublic/jakarta-tomcat-5/tomcat.nsi,v
retrieving revision 1.34
diff -u -r1.34 tomcat.nsi
--- tomcat.nsi  16 Jun 2003 21:15:40 -0000      1.34
+++ tomcat.nsi  22 Sep 2003 13:15:33 -0000
@@ -130,7 +130,7 @@
 
   Call configure
 
-  ExecWait '"$INSTDIR\bin\tomcatw.exe" //IS//Tomcat5 --DisplayName "Apache
Tomcat" --Description "Apache Tomcat @VERSION@ Server -
http://jakarta.apache.org/tomcat/";  --Install "$INSTDIR\bin\tomcat.exe"
--ImagePath "$INSTDIR\bin\bootstrap.jar" --StartupClass
org.apache.catalina.startup.Bootstrap;main;start --ShutdownClass
org.apache.catalina.startup.Bootstrap;main;stop --Java java --JavaOptions
-Xrs --Startup manual'
+  ExecWait '"$INSTDIR\bin\tomcatw.exe" //IS//Tomcat5 --DisplayName "Apache
Tomcat" --Description "Apache Tomcat @VERSION@ Server -
http://jakarta.apache.org/tomcat/";  --Install "$INSTDIR\bin\tomcat.exe"
--ImagePath "$INSTDIR\bin\bootstrap.jar" --StartupClass
org.apache.catalina.startup.Bootstrap;main;start --ShutdownClass
org.apache.catalina.startup.Bootstrap;main;stop --Java java --JavaOptions
-Xrs#-Djava.endorsed.dirs="$INSTDIR\bin;$INSTDIR\common\endorsed"#-Dcatalina
.base="$INSTDIR"#-Dcatalina.home="$INSTDIR"#-Djava.io.tmpdir="$INSTDIR\temp"
--Startup manual'
 
 SectionEnd


-----Original Message-----
From: Oxley, David [mailto:[EMAIL PROTECTED] 
Sent: Monday, September 22, 2003 2:04 PM
To: 'Tomcat Developers List'
Subject: RE: Tomcat 5.0.12

Remy, 
The service installed by the installer doesn't start. I think it is because
it is missing the java.endorsed.dirs, catalina.base, catalina.home and the
java.io.tmpdir parameters. See the attached diff. I can't build the
installer so haven't tested this.
Ok. Rather than changing the syntax of adding a service maybe the installer
could also add a template to the registry or a file (Like the wsdd of a web
service) and tomcatw.exe could bring up a GUI to add a new service from the
template.
To add a second Apache service is like this: 
apache -k install -n Apache2_2 -f %APACHE2_HOME%\conf\httpd2.conf 
To add a second Tomcat service is like this: 
tomcatw.exe //IS//Tomcat5 --DisplayName "Apache Tomcat" --Description
"Apache Tomcat 5.1.12 Server - http://jakarta.apache.org/tomcat/"  --Install
"C:\Tomcat\Home\bin\tomcat.exe" --ImagePath
"C:\Tomcat\Home\bin\bootstrap.jar" --StartupClass
org.apache.catalina.startup.Bootstrap;main;start --ShutdownClass
org.apache.catalina.startup.Bootstrap;main;stop --Java auto --JavaOptions
-server#-Xms512m#-Xmx512m#-Xrs#-Djava.endorsed.dirs="C:\Tomcat\Home\bin;C:\T
omcat\Home\common\endorsed"#-Dcatalina.base="C:\Tomcat\BaseServer1"#-Dcatali

na.home="C:\Tomcat\Home"#-Djava.io.tmpdir="C:\Tomcat\BaseServer1\temp" 
--Startup manual --StdOutputFile C:\Tomcat\BaseServer1\logs\jvm.stdout 
--StdErrorFile C:\Tomcat\BaseServer1\logs\jvm.stderr --Arguments "-config
C:\Tomcat\BaseServer1\conf\server.xml" 
Dave. 
> -----Original Message----- 
> From: Remy Maucherat [mailto:[EMAIL PROTECTED] 
> Sent: Monday, September 22, 2003 1:21 PM 
> To: Tomcat Developers List 
> Subject: Re: Tomcat 5.0.12 
> 
> Oxley, David wrote: 
> 
> > Wo, hang on there Remy. I'm sorry, I really didn't mean to cause 
> offence. 
> > 
> > Point 1, Ok, fair enough, I'm a twat. But I did ask the question! When 
> is 
> > mod_jk2 going to replace mod_jk anyway? 
> 
> I don't know. It is not critical IMO, as mod_jk works fine. 
> 
> > On point 2. I downloaded the zip. I have just downloaded the exe to see 
> what 
> > shortcuts you are talking about and Ok, a nice screen to configure the 
> > service. I did read the documentation. I also had to look in a readme 
> file 
> > in cvs Jakarta-commons/daemon to find out how procrun is run (which 
> doesn't 
> > even mention the //ES// parameter), but if you're telling me that adding

> a 
> > service in the set up I described is user friendly then I have to 
> disagree. 
> > That's not to say, I don't think it's heading in the right direction, 
> > because I think it is. But it took 5 minutes to get TC5 up and running 
> with 
> > jk_nt_service and about 2 hours to sort it out with procrun. 
> 
> If you want the "do-it-yourself" experience, then use the .zip. Setting 
> up Tomcat with the service is meant to be done through the installer, so 
> the user experience is decent. 
> 
> Besides, the wrapper tool is external to Tomcat. If you want to use the 
> old JavaService or jk_nt_service, then you can. 
> 
> > And I think maybe I worded it a bit harshly. We will be moving onto TC5 
> as 
> > soon as its final (which we didn't do for TC4.0!). 
> > 
> > I was going to look at writing some code tonight so that the Apache HTTP

> > Service Monitor picks up and controls TC5 services and also look at how 
> > procrun (because it is mainly there) can be improved. 
> 
> Personally, I like the current syntax. Unlike you, I think it is 
> complete, and rather intuitive. -1 to change it. 
> 
> Remy 
> 
> 
> 
> --------------------------------------------------------------------- 
> To unsubscribe, e-mail: [EMAIL PROTECTED] 
> For additional commands, e-mail: [EMAIL PROTECTED] 
> 
> 
> ________________________________________________________________________ 
> This e-mail has been scanned for all viruses by Star Internet. The 
> service is powered by MessageLabs. For more information on a proactive 
> anti-virus service working around the clock, around the globe, visit: 
> http://www.star.net.uk 
> ________________________________________________________________________ 
  


________________________________________________________________________
This e-mail has been scanned for all viruses by Star Internet. The
service is powered by MessageLabs. For more information on a proactive
anti-virus service working around the clock, around the globe, visit:
http://www.star.net.uk
________________________________________________________________________

Reply via email to