Amy Roh wrote:
Amy Roh wrote:

[EMAIL PROTECTED] wrote:
There doesn't seem many methods changing isValid to false. invalidate is
another one, and it calls expire. As long as all the methods which
invalidate the session right away expire them, it should be ok I think.

IMHO, not calling expire() because no method changes isValid to false doesn't seem like a clean approach. Moreover,

Well, where else to expire on access if the maximum interval was reached ? I like it (but I didn't do it). Does it actually cause a bug ?


PersistentManagerBase.processExpires() keeps expire() making it not
consistent.

Maybe. However, this was because in 4.1.x, isValid didn't expire the session, and this code wasn't updated. When I merged all background processing threads, I simply did a cut & paste of the code.


Rémy



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to