[EMAIL PROTECTED] wrote:
markt 2004/04/24 08:12:00
Modified: catalina/src/share/org/apache/catalina/core
ApplicationDispatcher.java
Log:
- Fix bug19801. Request dispatcher does not set empty javax.servlet.include request attributes
on nested includes. Based on a patch suggested by Matthias Ernst
- Ported from TC4.
I have a bad feeling about this "fix".
Are you absolutely certain the issue was valid ? Also, setting the value as null seems bad to me.
-1 for the change for the time being.
I reviewed the bug: I am convinced this was working fine with the current code (all the setAttribute with a null value end up not doing anything, as they are treated as special already - and there's no delegation for the include special attributes). Did you test it ?
So -0 for the change, since it doesn't actually do anything except introducing useless operations.
(for TC 4, the patch is very likely useful)
Rémy
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
