luehe 2004/05/12 16:59:20
Modified: jasper2/src/share/org/apache/jasper/compiler
TagFileProcessor.java
Log:
- Avoid including a link to line number in build.xml:
'ant' is adding the build.xml line number when catching the exception
thrown by JspC.execute(). I don't think there is anything we can do to
avoid this.
- Include full path of the JSP that contains the error:
Done!
- Text "org.apache.jasper.JasperException" is unnecessary:
The exception class name is printed by JasperException.toString(),
which is inherited from java.lang.Throwable.toString():
public String toString() {
String s = getClass().getName();
String message = getLocalizedMessage();
return (message != null) ? (s + ": " + message) : s;
}
We could override JasperException.toString() to suppress the
exception class name and just output the exception message.
I agree the exception class name is redundant when using JspC,
but it is useful info when compiling via the JspServlet.
Revision Changes Path
1.59 +3 -3
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java
Index: TagFileProcessor.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java,v
retrieving revision 1.58
retrieving revision 1.59
diff -u -r1.58 -r1.59
--- TagFileProcessor.java 6 May 2004 22:55:23 -0000 1.58
+++ TagFileProcessor.java 12 May 2004 23:59:19 -0000 1.59
@@ -216,17 +216,17 @@
String nameGiven = n.getAttributeValue("name-given");
String nameFromAttribute = n.getAttributeValue("name-from-attribute");
if (nameGiven == null && nameFromAttribute == null) {
- err.jspError("jsp.variable.either.name");
+ err.jspError("jsp.error.variable.either.name");
}
if (nameGiven != null && nameFromAttribute != null) {
- err.jspError("jsp.variable.both.name");
+ err.jspError("jsp.error.variable.both.name");
}
String alias = n.getAttributeValue("alias");
if (nameFromAttribute != null && alias == null ||
nameFromAttribute == null && alias != null) {
- err.jspError("jsp.variable.alias");
+ err.jspError("jsp.error.variable.alias");
}
String className = n.getAttributeValue("variable-class");
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
