remm 2004/06/23 01:25:04
Modified: catalina/src/share/org/apache/catalina/valves RequestDumperValve.java RequestFilterValve.java JDBCAccessLogValve.java ErrorReportValve.java AccessLogValve.java PersistentValve.java ValveBase.java ExtendedAccessLogValve.java RemoteAddrValve.java RemoteHostValve.java catalina/src/share/org/apache/catalina/connector RequestFacade.java Constants.java ResponseFacade.java catalina/src/share/org/apache/catalina Container.java Pipeline.java Realm.java Service.java Valve.java catalina/src/share/org/apache/catalina/core DummyRequest.java StandardWrapperValve.java StandardPipeline.java StandardServer.java DummyResponse.java ApplicationDispatcher.java StandardHostValve.java ApplicationFilterFactory.java ContainerBase.java StandardEngineValve.java StandardService.java StandardContextValve.java catalina/src/share/org/apache/catalina/authenticator SingleSignOn.java NonLoginAuthenticator.java FormAuthenticator.java DigestAuthenticator.java SSLAuthenticator.java BasicAuthenticator.java AuthenticatorBase.java catalina/src/share/org/apache/catalina/startup Embedded.java Catalina.java catalina/src/share/org/apache/catalina/realm RealmBase.java JAASMemoryLoginModule.java catalina/src/share/org/apache/catalina/mbeans ServerLifecycleListener.java MBeanFactory.java ConnectorMBean.java MBeanUtils.java . build.xml modules/cluster/src/share/org/apache/catalina/cluster/tcp ReplicationValve.java Added: catalina/src/share/org/apache/catalina/connector CoyoteOutputStream.java Connector.java Response.java CoyoteInputStream.java CoyoteAdapter.java MapperListener.java LocalStrings.properties LocalStrings_es.properties OutputBuffer.java LocalStrings_ja.properties LocalStrings_fr.properties CoyoteReader.java InputBuffer.java mbeans-descriptors.xml CoyoteWriter.java CoyotePrincipal.java Request.java Removed: catalina/src/share/org/apache/catalina/connector HttpResponseFacade.java HttpRequestFacade.java catalina/src/share/org/apache/catalina HttpRequest.java ValveContext.java HttpResponse.java Connector.java Request.java Response.java catalina/src/share/org/apache/coyote/tomcat5 OutputBuffer.java CoyoteResponseFacade.java CoyoteRequestFacade.java MapperListener.java CoyoteServerSocketFactory.java LocalStrings_ja.properties CoyoteAdapter.java LocalStrings_fr.properties LocalStrings.properties CoyoteConnector.java CoyoteReader.java Constants.java CoyotePrincipal.java LocalStrings_es.properties CoyoteOutputStream.java CoyoteInputStream.java CoyoteWriter.java CoyoteResponse.java CoyoteRequest.java mbeans-descriptors.xml InputBuffer.java catalina/src/share/org/apache/catalina/core StandardValveContext.java catalina/src/share/org/apache/catalina/net DefaultServerSocketFactory.java ServerSocketFactory.java Log: - Move Coyote adapter to o.a.catalina.connector. - Remove interfaces for Request/Response and move to concrete classes. - Remove a lot of RTTI and casts on Request/Response. I likely missed some, so this is a WIP. - I'm using version number 5.5 for this refactoring, as an indication that this is no longer 5.0.x. - Move back to the valve pattern of Tomcat 4.0 beta 1 (I feel old now :( ), but without the double chaining. The extra robustness of the valve context is nice, but it added complexity (and was slower) and overall wasn't needed. - In the end, I didn't remove Logger yet (it'll be my next commit :) ).
This commit was sponsored by Eclipse 3 RC 1 and its refatoring features :) Somehow, they spell that "refactoring" in the menus, but it's evidently a mistake, as the features are powerful enough to warrant the Genuine Refatoring (R) label.
I think it should still build, but I didn't do a fresh checkout to verify. Let me know.
Rémy
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
