DO NOT REPLY [Bug 31753] New: - inconsistency in #authenticate(Connection, ...) for JDBCRealm and DataSourceRealm

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31753>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31753

inconsistency in #authenticate(Connection, ...) for JDBCRealm and DataSourceRealm

           Summary: inconsistency in #authenticate(Connection, ...) for
                    JDBCRealm and DataSourceRealm
           Product: Tomcat 5
           Version: Nightly Build
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Catalina
        AssignedTo: [EMAIL PROTECTED]
        ReportedBy: [EMAIL PROTECTED]


I couldn't help noticing the inconsistency in #authenticate(Connection, String, 
String) for JDBCRealm and DataSourceRealm.

- Getting dbCredentials
JDBCRealm:
  if (rs.next()) {
    dbCredentials = rs.getString(1);
  }

DataSourceRealm:
  while (rs.next()) {
    dbCredentials = rs.getString(1);
  }

- Getting roles
JDBCRealm:
  while (rs.next()) {
    String role = rs.getString(1);
    if (null!=role) {
      roleList.add(role.trim());
    }
  }

DataSourceRealm:
  while (rs.next()) {
    list.add(rs.getString(1).trim());
  }

I think the JDBCRealm approach is better in both cases.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]