>>>>> "Mike" == Mike Frysinger <[email protected]> writes:

Mike> 2011-05-26  Mike Frysinger  <[email protected]>
Mike>   * remote-sim.c (gdbsim_open): Add the strlen of " --sysroot=" and
Mike>   gdb_sysroot to the "len" variable.  Append both to "arg_buf".

It seems reasonable to me.  Ok.

Mike> +  strcat (arg_buf, gdb_sysroot);

It seems like this will give wrong results if the sysroot needs quoting.
But, this problem could affect other arguments here.
Offhand it seems like it would be better if this code directly built
sim_argv rather than building a string and converting it, but I don't
know if any odd issue is lurking.

Tom
_______________________________________________
Toolchain-devel mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/toolchain-devel

Reply via email to