Hi Dan, I have given the webrev a cursory review and have not noticed anything that looks broken. But as a previous contributor, reviewer and a user I have some nits:
The changes add to the mishmash of ksh vie sh functionality. For example "[[" vie "[" for test and "print" vie "echo" for output. As webrev is a Korn shell script I prefer ksh syntax. Bourne shell test variants could then be cleared up: [ ! -z "$X" ] vie [[ -n $X ]] [ "$X" = "" ] vie [[ -z $X ]] Other nits: line 261: incorrect indentation. line 1494: Comment is repeated from line 1320. And a suggestion... Have frame diffs print the number of changes: i.e. "Diff [12 ] of 14" I've synched up my version of webrev with this one. Many thanks :-) Stacey Marshall This message posted from opensolaris.org _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
