Stephen Hahn wrote:
* Stephen Lau <[EMAIL PROTECTED]> [2006-11-29 16:54]:
Stephen Lau wrote:
I'm looking at porting add-gateling, and here's my current idea for how
to do it:
1. user foo does a clone (or pull)
2. map OpenSolaris.org username foo to their email address via webapp
3. lookup this project/repository in the app to find the notification
mailing addr for it
4. query mailman to see if that mailing addr is an opensolaris.org
mailman-managed list
4a. if not, then email that address and let them know this user
did a clone/pull
4b. if so, then call mailman's CLI to subscribe the user's email
does that seem reasonable with folks?
4a is needed in the case that projects only have one committer, and
don't have a mailing list for notifications, or for some reason or
another don't have the notification address set to an opensolaris.org
mailman managed list. I figure in that case, we can send an email saying:
"user foo ([EMAIL PROTECTED]) pulled a copy of scm-migration/ongk"
Sound reasonable?
Oh, I forgot to mention. I'm rewriting add-gateling as a Mercurial hook
to be fired upon the 'outgoing' hook.
I'm writing it to be an inline Python hook, so it will no longer be a
ksh script, if people care.
(I must have missed this on the first pass. Sorry.)
No apology needed, mailman seems to be delivering things out of order
today. I still haven't received my original email I sent :-P
So the new model is "add committer; on committer's first pull, send
informative message", right? Seems sensible, avoids some aspects of
webapp changes, but leads me to some questions:
- Where is the state that a committer has done a first pull? (The
mailing list, I guess. What if there's only the alias case you
mention above? Does the committer keep getting the mail?)
The committer wouldn't get any email.. one of two results happen:
4a) if the notification address is NOT an os.o mailing list, then the
notification address gets an email that the committer has subscribed
4b) if the notification address is an os.o mailing list, then the
committer get subscribed to the notification list
We could certainly add something to send the committer an email though,
and that's an interesting (and good) idea.
- What file are they sent? Could a project use a different file than
onnv-gate does?
This could/should perhaps be something we can add to the SCM webapp? Or
we could say each repository should have in their root directory a
"NEW_COMMITTER" text file that gets sent to each new committer? That
way it's under SCM control too. :)
(and then Gary doesn't have to do any additional webapp work ;-))
- If I change the file contents, can I make sure everyone gets a new
copy? (Should I do that?)
If it was under SCM control in the repository within question, then it
would be easy - because everyone would see it's been updated, and could
go pull new copies; rather than emailing it to everyone.
Anyway, your message should become a new subsection of Section 4 in
the design document, once you've expanded it a bit.
Yup, I was hoping to get some discussion on it first to get other
thoughts, and then put it into the design doc once we had some consensus.
cheers,
steve
--
stephen lau // [EMAIL PROTECTED] | 650.786.0845 | http://whacked.net
opensolaris // solaris kernel development
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
