Peter Memishian wrote: > > I agree. If I make a whitespace change I want to see it, > > and as a code reviewer I want to see it too. Basically, > > I want to see every change period. > > Though the current default does have some advantages. For instance, > suppose a 50 line block of code becomes indented via a new `if' block. > With -b, all 50 lines will show up as changed, and as a reviewer you'll > almost certainly miss an accidental change to one of those 50 lines. > > As a reviewer, for C code I rarely care about changes in whitespace. >
webrev can and is used for more than C, namely python, where whitespace at the front of lines is significant and can cause subtle bugs when used incorrectly. -jhf- _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
