On Fri, Mar 07, 2008 at 03:58:44PM -0500, James Carlson wrote:
> Will Fiveash writes:
> > This wx is the same as /ws/onnv-gate/usr/src/tools/scripts/wx.sh
> > correct? If so, then yes I'd say it's ready for review as it's only
> > been used about a zillion times. 8^)
>
> Not correct; it's been modified and some of the things it invokes have
> been completely rewritten.
>
> > On the other hand, I'm confused as to why wx is being reviewed since I
> > thought the plan was to move to Mecurial not Teamware in which case wx
> > becomes irrelevant. I'm sure I'm missing something here.
>
> It's an integrated set of tools that support both Teamware and
> Mercurial.
>
> The changes are really quite extensive.
I looked at the webrev that Mike generated for wx and in general the
changes look okay to me. A nit is that the wx_usage() probably needs to
be reviewed and changed some for external users. For example I see:
See <http://onnv.eng/wx.html> for usage tips.
Some of the other command descriptions may need more detail (or in the
wx man page). For example the wx backup command doesn't indicate that
it will backup to wx.backup in the user's home dir by default.
--
Will Fiveash
Sun Microsystems Office x64079/512-401-1079
Austin, TX, 78727 (TZ=CST6CDT), USA
Internal Solaris Kerberos/GSS/SASL website: http://kerberos.sfbay
Info about krb-diag: http://kerberos.sfbay/krb-tool-info.html
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
