Roland Mainz wrote:
Hi!
----
Can you please take a quick look at
http://cr.opensolaris.org/~gisburn/cr6842892_webrev_cleanup_002/ and
check whether there are any problems with the patch ?
<snip>
- Add builtin manpage via --man (the same way as I did the --man support
for "bldenv"). The seperate webrev.1 file in the sources will be removed
in the next webrev and instead the build will use $ webrev --nroff # on
the script to get the *roff source for the manpage (this should lower
maintaince since "getopts" string and manpage are now one string/blob).
I am not sure I follow. The webrev for this change (what is the CR
number, by the way ?) dispays just webrev.sh. It looks like the removal
of webrev.1 is missing in the changeset.
Also, I have 3 concerns regarding this particular change:
- it seems it's time to stop the explosion of the script in terms of
space; it's way too long already.
- is the generated man page really the same as the old one ? Maybe
you could produce a diff of the original man page and the man page
generated from the 'USAGE' field ?
- not sure if sucking the man page into the script is the right thing
to do (say the script will be rewritten into Python one day). Why is
that necessary ?
v.
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
