James C. McPherson wrote:
Hi folks, as I mentioned to Rainer eariler this evening, I've been working on changes for the following CRs: 6414832 SUNWonbld gk account should be removed 6536468 date in Nevada motd should be changed 6855668 webrev mangles dates in non-Romanised locales 6866716 estimation of max-jobs for /.make.machines is incorrect 6589104 make POUND_SIGN less of a drag 6750554 build rule for mcs gives shell+date a real workout I'd like to get review comments from the community within the next 2 days (by 8pm Australia/Queensland time on Thursday 24th), so that I've got a chance of making the current build. The webrev is available at http://cr.opensolaris.org/~jmcp/6414832/webrev
Hi everybody, thankyou to James, Rich, Danek and Roland for their comments, I've incorporated them into a new version of the webrev. The only explanatory thing left is regarding Danek's query: ------ Is the new way of computing POUND_SIGN in Makefile.master on top of setting POUND_SIGN in nightly and bldenv just belt and suspenders? Shouldn't the first do the trick? (Cute trick, BTW.) ------ The answer is that while most people are using bldenv or nightly with an appropriate env file, some (including myself) use "ws" or some other method to set $SRC, $ROOT etc. Having the PRE_POUND etc in Makefile.master makes sure that those people also see the benefit of the changes. I've included a comment to this effect in Makefile.master. The updated webrev is at the same place, further comments are welcomed. Thankyou again, James -- Senior Kernel Software Engineer, Solaris Sun Microsystems http://blogs.sun.com/jmcp http://www.jmcp.homeunix.com/blog _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
