On Wed, 13 Jan 2010, Mike Kupfer wrote:

Mike Kupfer writes:

Mark J Nelson writes:

Mark> usr/src/tools/scripts/nightly.sh
Mark> 81 Should this use $BUILD_DATE?

Mike> Yes, that seems cleaner.

Oops, I'm afraid I didn't look closely at the format used for
BUILD_DATE.  It uses the English 3-letter abbreviation for the month, so
we end up with file names that look like

   on-crypto-2010-Jan-12-nd.i386.tar.bz2

I'd rather use all numbers for the date.  First, it'll mean that sorting
by file name also gives you sorting by date.  Second, I think it's
friendlier for people whose native language is other than English.

I have a mild preference for

   on-crypto-20100112-nd.i386.tar.bz2

because it's more compact.  But it's harder visually to parse, so I'm
okay with

   on-crypto-2010-01-12-nd.i386.tar.bz2

I prefer that one, because it is easier to visually parse.  I'm sorry
I haven't reviewed yet, do you have an updated webrev that incorporates
the comments so far? thanks!

Valerie
--
Valerie Fenwick, http://blogs.sun.com/bubbva/ @bubbva
Solaris Security Technologies, Developer, Sun Microsystems, Inc.
17 Network Circle, Menlo Park, CA, 94025.
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org

Reply via email to