Richard Lowe wrote:
> Ali Bahrami wrote:
>> You are hitting a new mapfile keyword. Support for it went into build 58
>> at the end of January with
>>
>> PSARC 2007/026 ELF symbol sort sections
>> 6475344 DTrace needs ELF function and data symbols sorted by address
>>
>> Use of the feature was introduced into ON with build 66 in May:
>>
>> 6518331 Eliminate duplicate addresses from ON ELF symbol sort sections
>>
>> That added the mapfile NODYNSORT keywords that you're hitting.
>>
>
> Then shouldn't the putback for 6518331 have bumped the version check in
> nightly.sh, so people using a too-old linker get a warning?
>
> -- Rich
> _______________________________________________
> tools-linking mailing list
> tools-linking at opensolaris.org
Rich,
Interesting point. Maybe it should have. I wasn't aware of that check in
nightly.sh. I've been here for about a year and a half, and no one has
ever mentioned it to me. That explains why I didn't update it.
Now on to whether it should have been...
I went digging into what nightly.sh does, and where that version number
that it keys off of comes from. It turns out to be the SCCS version of the
file usr/src/cmd/sgs/packages/common/SUNWonld-README, which is a file where we
(linker group) track all linker changes. Not a bad choice, since every linker
change gets recorded there, and the resulting SCCS version is unique,
monotonically
increasing, and easily correlated to the change that caused it.
The current revision for SUNWonld-README is 587. The version nightly.sh is
checking
against is 422. That revision dates to March 2005, over 2 years ago. Of course,
there
have been many linker changes in that time that would have required a newer
linker to
be installed to build ON, so one might expect nightly.sh to be using a newer
value.
The guy who can explain all this (and what our policy is about that check in
nightly.sh)
is out of town for a couple of weeks. I'll ask him about it when he gets back,
and we'll
fix whatever we should.
Something that definitely should have happened, but didn't, is that my heads up
message for change that started using NODYNSORT in ON (6518331) should have said
that you need a new linker. I'll make sure that happens next time.
- Ali
