#17238: prop224: Implement HSDir support -------------------------------------------------+------------------------- Reporter: dgoulet | Owner: dgoulet Type: enhancement | Status: | needs_review Priority: High | Milestone: Tor: | 0.2.9.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-hs, prop224, TorCoreTeam201608, | Actual Points: review-group-7 | Parent ID: #12424 | Points: parent Reviewer: asn | Sponsor: | SponsorR-must -------------------------------------------------+-------------------------
Comment (by asn): Replying to [comment:9 dgoulet]: > Ok _'''big'''_ branch here. Some of it has been reviewed already in different branches but this one bring the whole feature together. Unfortunately, we need a single branch because all child tickets depends on each other. > > The branch contains basically in order of commit appearance: #18515, #19024, #18571, #18572, #19205 > > Branch is `ticket17238_029_01`. Merge request here: > > https://gitlab.com/dgoulet/tor/merge_requests/9 Hello. Did an initial gitlab review here of the following commits: {{{ 250cde9 * prop224: Descriptor decoding implementation 394266f * prop224: Descriptor encoding implementation 57084a4 * prop224: Add new cert type for hidden service 61041e2 * trunnel: Uncomment link_specifier so we can use it ceaf43b * Move token parsing code to parsecommon.{c|h} }}} I will review those commits more ASAP, and also move on to the other commits. (Also `actual_review_points == 0.5` so far) -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17238#comment:12> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs