#13953: Self-test reachability test - Listen address from ORPort is ignored, it uses default address unless specified via Address argument -----------------------------------------------+--------------------------- Reporter: s7r | Owner: teor Type: enhancement | Status: | merge_ready Priority: Medium | Milestone: Tor: | 0.2.9.x-final Component: Core Tor/Tor | Version: Tor: | 0.2.5.10 Severity: Normal | Resolution: Keywords: review-group-7, TorCoreTeam201608 | Actual Points: 1.0 Parent ID: #17782 | Points: 3 Reviewer: | Sponsor: -----------------------------------------------+--------------------------- Changes (by s7r):
* status: needs_review => merge_ready Comment: Nice to remove the duplicate code. I am happy with it, but I think we should reword the log message: '''''[...]If you have a static public IPv4 address, set 'Address <IPv4>'[...]''''' If there's just a static IP address, this setting is unnecessary, Tor will just discover and use it. The setting is necessary when there are multiple public IP addresses and the user wants to use a certain one. Also substitute IPv4 with IP, simpler and should cover IPv6 as well in the future. Latest branch that includes teor's refactoring and the reworded log message is `bug13953`on https://github.com/gits7r/tor.git -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13953#comment:30> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs