#17178: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous -------------------------------------------------+------------------------- Reporter: teor | Owner: teor Type: enhancement | Status: | needs_review Priority: High | Milestone: Tor: | 0.2.9.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: rsos, tor-hs, TorCoreTeam201608, | Actual Points: 10 review-group-5, review-group-7 | Parent ID: | Points: 6.5 Reviewer: dgoulet | Sponsor: -------------------------------------------------+-------------------------
Comment (by asn): Replying to [comment:66 teor]: > Replying to [comment:65 dgoulet]: > > On the overall patch, I found minor things: > > > > * Long tab :) > > {{{ > > + if (rend_service_use_direct_connection(options, rp)) { > > + flags = flags | CIRCLAUNCH_ONEHOP_TUNNEL; > > + } > > }}} > > That snuck in during a merge. Fixed along with an end-of-file EOL in: > [feature-17178-v6 f239a1e] Appease make check-spaces > > > * `rend_service_reveal_startup_time()` is exactly the same thing as `rend_service_allow_direct_connection()` so making the reveal startup time function use `rend_service_allow_direct_connection()` could be a better choice as the requirement for now is for the service to allow direct connection. I like the separation of semantic here so something like this would be good I think: > > > > {{{ > > int rend_service_reveal_startup_time(const or_options_t *options) > > { > > return rend_service_allow_direct_connection(options); > > } > > }}} > > Changed in [feature-17178-v6 0b964a5] fixup! fixup! fixup! fixup! Implement Prop #260: Single Onion Services > > > I'm happy with the rest! I'll leave this in `needs_review` for asn to take a look at it. > > Over to asn then. OK did another pass over the branch, and suggested some mainly-aesthetic stuff in gitlab. Code looks cleaner and easier to analyze than before. BTW, why are these unix socket commits required for #17178? i.e. `Count unix sockets when counting client listeners`. I hope to find some time to test the branch later today. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17178#comment:68> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs