#19459: Write (C++) patch for window resizing parts -------------------------------------------------+------------------------- Reporter: gk | Owner: | arthuredelstein Type: task | Status: | needs_revision Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-torbutton-conversion, | Actual Points: TorBrowserTeam201608 | Parent ID: | Points: Reviewer: | Sponsor: | SponsorU -------------------------------------------------+-------------------------
Comment (by arthuredelstein): Replying to [comment:4 gk comment 4]: > So, the link gives me a 404. Thus, it is hard to say what the patch looks like :). Sorry! I've fixed the URL above. > That said, it seems there is at least the corresponding Torbutton one missing that backs the code we have out and just uses the Firefox one. Yes, I'll submit that patch as well. > That said, I was under the impression we can't fix the resizing problems on start-up at least from JS land. Thus, I bet Mozilla won't be happy with it which is why I thought we should try the C++ road. I couldn't rule out a C++ solution, but all the indications to me point to an entirely (or mostly) JS approach, because nearly all the existing code in Firefox for setting the dimensions of a new window are in JavaScript (`browser/base/content/browser.js` and friends). Replying to [comment:6 gk comment 6]: > Oh, another thing while looking at the code: we have a max width and max height of 1000 and we round to multiples of 200x100. What were you reasons for changing this? The max width and height I chose to match as closely as possible Mozilla's latest preferred dimensions: https://dxr.mozilla.org/mozilla- central/rev/1a5b53a831e5a6c20de1b081c774feb3ff76756c/browser/base/content/browser.js#963 but if we want to stick to 1000x1000, I'm also fine with that. I will also change the rounding to 200x100, which I had misremembered. I'm working on a new (hopefully improved) version of the patch, so no need to review the last one further. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19459#comment:7> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs