#20001: Infer running and valid from presence in consensus -------------------------------------------------+------------------------- Reporter: nickm | Owner: nickm Type: enhancement | Status: | needs_revision Priority: Medium | Milestone: Tor: | 0.2.9.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: prop272, TorCoreTeam201608, review- | Actual Points: .1 group-8 | Parent ID: | Points: .2 Reviewer: | Sponsor: -------------------------------------------------+------------------------- Changes (by asn):
* status: needs_review => needs_revision Comment: Review: - The following change is wrong and probably accidental: {{{ - rs->is_flagged_running = 1; + rs->is_flagged_running = 1 *; }}} Also please squash both commits as they are overwriting each other. - I don't see the `MIN_METHOD_FOR_EXCLUDING_INVALID_NODES` consensus method defined anywhere. However, it seems like it's included in the #20002 branch so this is just a rebase issue. - As a step further, does this mean that we can eventually deprecate the `is_valid` and `is_flagged_running` flags, and assume that they are set? When can this be done? I guess we can already do this for `is_valid` but we need to wait till `MIN_METHOD_FOR_EXCLUDING_INVALID_NODES` becomes standard to remove `is_flagged_running`. Marking this as `needs_revision` for the fist comment. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20001#comment:14> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs