#20111: use Unix domain sockets for SOCKS port by default -------------------------------------------------+------------------------- Reporter: mcs | Owner: tbb- | team Type: defect | Status: | needs_review Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-torbutton, tbb-security, tbb- | Actual Points: sandboxing, TorBrowserTeam201610R | Parent ID: #14270 | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by arthuredelstein): A few very minor comments: * "extensions.torlauncher.socks_port_use_socket" is a confusing name to me, because we are using a TCP socket when it is false. Maybe call it "socks_port_use_ipc", as this would also cover the named pipe scenario if we later get it working in Windows? Similar for the env var TOR_SOCKS_SOCKET. * `_strUnescape`: It would be nicer if this function simply returned the unescaped string, and threw an exception if it failed. (Although maybe you want to keep it this way to be consistent with the other copy in Tor launcher.) * `unescapeTorString`: I would suggest defining this after `_strUnescape` is defined in utils.js, because it refers to it. Otherwise looks good to me. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20111#comment:20> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs