#20261: tor_fragile_assert() when Unix domain socket is used -----------------------+------------------------------------ Reporter: mcs | Owner: yawning Type: defect | Status: needs_review Priority: High | Milestone: Tor: 0.2.9.x-final Component: Core Tor | Version: Tor: 0.2.9.2-alpha Severity: Normal | Resolution: Keywords: tbb-needs | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -----------------------+------------------------------------ Changes (by yawning):
* status: assigned => needs_review Comment: This is ugly because we never bothered to treat AF_UNIX as a full class citizen. In particular `tor_addr_t` doesn't contain the path at all, so when we go to compare them, there isn't any information regarding the address beyond the family. The correct solution is probably to extend tor_addr_t to Do The Right Thing, but this branch should cover Tor Browser's use cases. The first commit is probably safe to take since it's the `IsolateClientAddr` change, the second may be more controversial. https://git.schwanenlied.me/yawning/tor/src/bug20261 -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20261#comment:6> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs