#20082: Lower initial descriptor upload delay for hidden services -------------------------------------------------+------------------------- Reporter: twim | Owner: Type: enhancement | Status: | needs_revision Priority: Medium | Milestone: Tor: | 0.3.0.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-hs, research, proposal-needed?, | Actual Points: TorCoreTeam201610, 030-proposed | Parent ID: | Points: Reviewer: teor | Sponsor: | SponsorR-can -------------------------------------------------+------------------------- Changes (by teor):
* reviewer: => teor * milestone: Tor: 0.2.??? => Tor: 0.3.0.x-final Comment: Replying to [comment:26 twim]: > Replying to [comment:25 teor]: > > > Removed references to rend_service_reveal_startup_time(): > > * there are references in the comments as well. grep is your friend. > > Add REND_DIRTY_DESC_STABILIZING_PERIOD_TESTING > > * The logic here is inverted: the testing period needs to be used when TestingTorNetwork is 1. > > Thanks, good catches! Fixed. > > > In future, please add a short message to the commit saying what's changed. > > (These ones look like they will squash nicely into one commit, so no need to fix them.) > These ones are supposed to be squashed. There is no need to store thashy commits in `master`. ;) These all look good. > > This also needs a changes file. See tor/changes/ for examples, or read doc/HACKING/CodingStandards.md > Yeap, added changes file. As always, not sure about 'feature on ...' string. We don't use "feature on", only "bugfix on". And the changes file is usually shorter. Here's what I suggest we write for the changes file - they can be hard to get right: {{{ o Minor features (onion services): - Reduce onion service initial descriptor upload delay from 30s to 3s. If descriptor changes too soon after this (< 30s), log a warning about unreliable network connections. Closes ticket 20082. o Minor bugfixes (onion services): - Remove code that claimed to introduce an initial descriptor upload delay, but never actually worked. Closes ticket 12500, bugfix on tor-0.0.9pre6. }}} Here are the commands I used to find which release the bug was introduced in: {{{ git blame src/or/rendservice.c (look at the commits that changed the function) git show 4b76fe803 git describe --contains 4b76fe8 }}} -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20082#comment:27> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs