#20244: Move privacy checkboxes to about:preferences#privacy (proposed)
-------------------------------------------------+-------------------------
Reporter: arthuredelstein | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-usability, | Actual Points:
TorBrowserTeam201610R |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):
* status: needs_revision => needs_review
Comment:
Replying to [comment:5 mcs]:
> Replying to [comment:2 arthuredelstein]:
> > I've written patches for this, because it's going to make the problems
I encountered in #18093 much easier to solve.
>
> Kathy and I reviewed and ran with all of the patches. Nice work!
Comments below.
Thanks for the review!
> * There is a typo in the commit message for
38f3653b89ce3790d75b8652316f7381158d0af3 ("Bug Bug").
Fixed.
> * You sometimes treat `privacy.thirdparty.isolate` as a Boolean pref,
which does not seem correct.
Oops, good catch. Fixed.
> * When I clicked the button in about:plugins to enable plugins, no
warning prompt was displayed. Possibly related, there is no default value
for `plugins.disable` which caused this to appear on the browser console:
> {{{
> 16:26:17.523 NS_ERROR_UNEXPECTED: Component returned failure code:
0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]1
torbutton.js:2323:0
> }}}
Turns out I had consistently mistyped "plugin.disable" as
"plugins.disable". Fixed.
> * Please remove the following from
src/defaults/preferences/preferences.js:
> {{{
> extensions.torbutton.resist_fingerprinting
> extensions.torbutton.restrict_thirdparty
> }}}
Done. I have now also removed "extensions.torbutton.block_disk" in patch
20244.1 and use the "browser.privatebrowsing.autostart" pref instead.
> * Can we reduce the height of the preferences window? I cannot remember
how the height is determined, but on OSX there is now a lot of extra space
below the slider. Or maybe it is just remembering an old height that I set
by resizing.
I added maxwidth and maxheight properties to stop it from getting too big.
> * In the tor-browser patches, should we use the same labels as we have
in src/chrome/locale/en/torbutton.dtd? Or did you intentionally make them
different to verify that the overlay was working?
I did, but now I have made them the same.
> * Should we include the access keys in the overlay so they can be
localized?
Added.
Here are the new versions:
https://github.com/arthuredelstein/torbutton/commits/20244+1
https://github.com/arthuredelstein/tor-browser/commits/20244+1
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20244#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
