#20414: Donation banner on about:tor page for 2016 campaign -------------------------------------------------+------------------------- Reporter: arthuredelstein | Owner: Type: defect | Status: | needs_review Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: TorBrowserTeam201610R, crowdfunding | Actual Points: Parent ID: #20413 | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by mcs): Kathy and I reviewed the JS/HTML/CSS changes. They look okay; we noticed just a few small things: - The comment says "2016 Dec 1" for the start date but the code uses October 1st. - Please remove some of the console.log() statements. - "fitt" should be "fit" in one comment. - The CSS has some rules for other browsers, e.g., `-khtml-user-select: none` (but if the same CSS file is going to be used on the website, maybe you do not want to remove these). - It would be nice to clean up the `extensions.torbutton.donation_banner2016.shown_count` pref somehow. Maybe reset it after the end date has been reached? This is not a big deal though; I do not know if we cleaned up last year's pref. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20414#comment:10> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs