#19926: BUG warning in connection_ap_attach_pending: waiting for rendezvous
desc :*
------------------------------+------------------------------------
Reporter: cypherpunks | Owner:
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor | Version: Tor: 0.2.9.1-alpha
Severity: Normal | Resolution:
Keywords: bug, regression? | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
------------------------------+------------------------------------
Comment (by arma):
Replying to [comment:8 arma]:
> Have we audited all the cases where a stream can go from
AP_CONN_STATE_CIRCUIT_WAIT to AP_CONN_STATE_RENDDESC_WAIT, to make sure
that we frob pending_entry_connections appropriately in all of them?
There are four places where we transition from some state into
AP_CONN_STATE_RENDDESC_WAIT: in circuit_get_open_circ_or_launch() in
circuituse.c, in connection_ap_handshake_rewrite_and_attach() in
connection_edge.c, in rend_client_send_introduction() in rendclient.c, and
in rend_client_report_intro_point_failure() in rendclient.c. But in all
four of these cases, we call connection_ap_mark_as_non_pending_circuit()
right before. So I think we should be ok there.
Next, have we audited all the cases where we add a stream to
pending_entry_connections, to make sure we aren't in state
AP_CONN_STATE_RENDDESC_WAIT when we do it?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19926#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
