#20147: [PATCH] (re-)dzip.sh: various improvements -----------------------------------------------+-------------------------- Reporter: rustybird | Owner: tbb-team Type: enhancement | Status: closed Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: fixed Keywords: tbb-gitian, TorBrowserTeam201612R | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -----------------------------------------------+-------------------------- Changes (by gk):
* keywords: tbb-gitian => tbb-gitian, TorBrowserTeam201612R * status: needs_revision => closed * resolution: => fixed Comment: Replying to [comment:20 rustybird]: > What a nightmare! It's making me ill that this has turned into such a time sink for you, so sorry. I've found some instructions for (kind of) getting Gitian to work on Qubes in a Bitcoin context, maybe I can adapt these to Tor Browser and really test my shit in the future: https://groups.google.com/d/msg/qubes-users/tnJnjlZgpGs/0bGDaHwiAgAJ No worries, thanks for your help! > Anyway, this seems to have uncovered a legit (though benign) bug in `windows/gitian-firefox.yml`: I've extracted `torbrowser-install-6.0.7_en- US.exe` and, in contrast to Linux and Mac, there simply is no `Browser/webapprt/omni.ja` on Windows. So that line could be deleted? Indeed, thanks! > (If you look through a successful Windows build log, it will probably show how the old `re-dzip.sh` ignored the `unzip`, `zip`, and `mv` failures and exited "successfully", because the last thing it did was remove the temporary directory.) Yes. I've fixed that with removing the offending line in commit fcda7b592553df7fb44a59f4d9341b424f4ad372 and reapplied your patch in commit cb3acb5f6a878e9b34f60b6d9bb2bacb5194a3b8. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20147#comment:21> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs