#21134: Fail if file is too large to mmap. --------------------------------------------+------------------------------ Reporter: junglefowl | Owner: Type: defect | Status: needs_review Priority: Medium | Milestone: Tor: | 0.3.0.x-final Component: Core Tor/Tor | Version: Tor: 0.2.9.8 Severity: Normal | Resolution: Keywords: tor_mmap_file, review-group-15 | Actual Points: Parent ID: | Points: Reviewer: nickm | Sponsor: --------------------------------------------+------------------------------ Changes (by nickm):
* status: needs_information => needs_review Comment: We build with large-file support by default, since we have "AC_SYS_LARGEFILE" in our configure.ac. Looking at the code, I think this needs these changes. * It needs a changes file (see doc/HACKING/GettingStarted.md) * We should really allow the case where st.st_size == SIZE_MAX. * This should be at least a warning, not an INFO message, since we can't really recover from this problem. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21134#comment:9> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs