#17847: Unify router_pick_directory_server_impl and router_pick_trusteddirserver_impl ----------------------------+------------------------------------ Reporter: teor | Owner: ahf Type: enhancement | Status: new Priority: Medium | Milestone: Tor: 0.3.0.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: easy, refactor | Actual Points: Parent ID: | Points: 2 Reviewer: nickm | Sponsor: ----------------------------+------------------------------------ Changes (by nickm):
* status: needs_review => new * keywords: easy, refactor, review-group-15 => easy, refactor Comment: Looks like a good start, and I'd be happy to take it as-is, but unless I'm missing something it doesn't yet actually unify the two functions yet? They're still two separate functions with mostly duplicated logic. I've merged it, with a change to pass tor_addr_t by reference rather than on the stack. Calling this ticket "new" again. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17847#comment:16> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs