#20765: adapt to new lines in votes and consensus and make the adaption to protocol changes easier ---------------------------------+----------------------------------- Reporter: iwakeh | Owner: metrics-team Type: enhancement | Status: needs_review Priority: Medium | Milestone: metrics-lib 1.6.0 Component: Metrics/metrics-lib | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: ---------------------------------+-----------------------------------
Comment (by iwakeh): Replying to [comment:8 karsten]: > ... > > (Just a thought, should `Number` be used instead of `Long` as the protocol numbers have unsigned int range?) > > Hmm, can you elaborate? Basically a version is just a positive number and that the spec chose an unsigned int range is probably due to the fact that integer is the usual default chosen in programming, but not that anyone envisions that many versions. To really have the concept of version number in java code a subclass of Number would be necessary that only accepts positive values, but that would be too much implementation for hardly any benefit. Still, using metrics-lib api I might feel better to call intValue() on Number rather than on Long (the highest version I saw so far was 4). But, that is a little 'esoteric' maybe. As said just a thought. I don't feel strongly about this. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20765#comment:10> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs