#21396: Torbutton breaks Session Manager addon -------------------------------------------------+------------------------- Reporter: HolD | Owner: tbb- | team Type: defect | Status: closed Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: fixed Keywords: tbb-6.5-regression, | Actual Points: TorBrowserTeam201703R, GeorgKoppen201702 | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+------------------------- Changes (by gk):
* status: needs_review => closed * resolution: => fixed Comment: Replying to [comment:12 mcs]: > Replying to [comment:11 gk]: > > What about `bug_21396` (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_21396&id=3a285294fe1db84b140db456900cdbf9a62bab0c) in my public Torbutton repo? > > The patch looks okay. Kathy and I tested it with browserleaks.com but not with the Session Manager add-on. Just a few small things that you may want to fix inside the `shouldLoad()` function: > 1. It is inconsistent to not prefix `uriFingerprinting` with `this.` (but the code seems to work). Oops, that's a remaining part of my first patch idea. :( > 2. It might be better to check `this.uriFingerprinting` first since the `schemeIs()` calls must take longer to execute than checking a Boolean JS variable. Fixed. > 3. Adding braces wouldn't hurt. Fixed. All those fixed are in commit 84ff007519fa475d36800e979169f961fe0c072e on `master`. Backported to `maint-1.9.6` with fc00aef1fd552784dfca72dcdbb78e72e2f9932e. Thanks! -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21396#comment:13> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs