#21598: Log a message when a hidden service has fewer introduction points than expected --------------------------+------------------------------------ Reporter: teor | Owner: Type: enhancement | Status: needs_revision Priority: Medium | Milestone: Tor: 0.3.1.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-hs | Actual Points: 0.1 Parent ID: #21446 | Points: 0.1 Reviewer: | Sponsor: --------------------------+------------------------------------ Changes (by dgoulet):
* status: needs_review => needs_revision Comment: This lgtm except I would simply add the onion address of the faulting service with something like: {{{ + log_fn(severity, LD_REND, "Hidden service %s wanted %d intro points, but " + "descriptor was updated with %d instead.", + service->service_id, + service->n_intro_points_wanted, have_intro); }}} Note that it's not being used with `safe_str_client()` so an operator can at least identify which service is being affected without restarting with `SafeLogging 0`... Feel free to change that if you think it's a bad idea. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21598#comment:2> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs