#21841: Refactor: include openssl headers from fewer modules --------------------------+------------------------------------ Reporter: nickm | Owner: nickm Type: enhancement | Status: needs_revision Priority: Medium | Milestone: Tor: 0.3.1.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: | Actual Points: .3 Parent ID: | Points: .3 Reviewer: | Sponsor: --------------------------+------------------------------------ Changes (by ahf):
* status: needs_review => needs_revision Comment: In commit `38fb651f0d740bef575ad7f95475cc504ea4cb8f`: {{{ + crypto_digest_add_bytes(sha_ctx_, (const char *)(inp2), (len2)); \ + crypto_digest_get_digest(sha_ctx_, (char *)out, 64); \ + crypto_digest_free(sha_ctx_); }}} and in the same commit: {{{ + crypto_digest_add_bytes(sha_ctx_, (const char *)(inp3), (len3)); \ + crypto_digest_get_digest(sha_ctx_, (char *)out, 64); \ + crypto_digest_free(sha_ctx_); \ }}} The `64` should probably be replaced with `DIGEST512_LEN`. Other than that it looks good - seems to simplify our code. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21841#comment:4> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs