#16225: Unify exception/error handling in metrics-lib ---------------------------------+----------------------------------- Reporter: karsten | Owner: karsten Type: enhancement | Status: needs_information Priority: Medium | Milestone: metrics-lib 1.7.0 Component: Metrics/metrics-lib | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: ---------------------------------+----------------------------------- Changes (by iwakeh):
* status: needs_review => needs_information Comment: Ok, I start from the opposite direction and hopefully we meet in the perfect middle :-) The use-case this ticket mostly refers to is bulk processing, i.e. there is a bunch of descriptors somewhere (file system, remote server) and metrics-lib fetches, synchronizes, and parses these files. One constraint is that there will always be some descriptors that cannot be parsed. From this scenario, I would conclude that methods like readDescriptors, parseDescriptors, collectDescriptors don't throw DescriptorParseExceptions, but simply process as much as possible and provide a list of problematic descriptors at the end, which the API using program can choose to ignore or process. Does this sound like the right use-case description? Regarding the code-example: configuration of a descriptor source by fluent-style (or method chaining) is fine, but metrics-lib currently has the DescriptorSourceFactory approach, which would need to be adapted. That is, I see two things: the ideas around the code of DescriptorSourceBuilder are ideas about a new way of configuration and not exception/error handling in metrics-lib, i.e. a different ticket (there is one for redesign of the interface hierarchy, I'll look for it). Second, the current configuration and descriptor source instanciation need to be considered together (in that other ticket). -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16225#comment:6> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs