#22148: prop140: conformance to proposal, unhandled corner cases --------------------------+------------------------------------ Reporter: nickm | Owner: nickm Type: defect | Status: needs_review Priority: Medium | Milestone: Tor: 0.3.1.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: #13339 | Points: .5 Reviewer: | Sponsor: Sponsor4 --------------------------+------------------------------------ Changes (by nickm):
* status: accepted => needs_review Comment: Replying to [ticket:22148 nickm]: > There are some remaining issues in my prop140_complete branch. > > We should [allocate] a protover for directories that support these new requests. Done in `prop140_aftermath_url`, which now I've tested. :) > Right now, we treat failures to apply a consensus diff as if the consensus download had failed. Is this what we should be doing? Still remains. I've made this into #22172 since it will take more thinking. > The proposal specifies a method for downloading diffs without using the X-Or-Diff-From-Consensus syntax. We should implement that on the server side. Done in `prop140_aftermath_url`. > Our proposal specifies networkstatus parameters, but the code doesn't implement them. Done in `prop140_aftermath_cfg`. > The proposal says that sha3 digests may be truncated in requests: I propose we do not implement that, and revise the proposal to match. Done in torspec in 28816242f9eaa5509dc400a48ade1e7c4a591717 and 522d75dd3969a4e220a113d38cf2c4497d264ab4. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22148#comment:5> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs