#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off -------------------------------------------------+------------------------- Reporter: gk | Owner: gk Type: defect | Status: | needs_information Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-usability, tbb-7.0-must-alpha, | Actual Points: ff52-esr, TorBrowserTeam201705, | GeorgKoppen201705 | Parent ID: | Points: Reviewer: | Sponsor: | Sponsor4 -------------------------------------------------+-------------------------
Comment (by gk): Replying to [comment:22 mcs]: > Replying to [comment:21 gk]: > > Well, that's not the same as in the attachment which is why I was asking. > > Ah. I forgot that we posted a patch in an attachment (work in progress) and then later we posted a pointer to what we thought was a better patch. The main difference between the two patches is where our hook is added (`nsExternalHelperAppService::DoContent()` vs. `nsExternalAppHandler::OnStartRequest()`). But you probably already knew that... > > Do you know if the patch we posted in the attachment fixes this bug on Linux? We did not try it because we were hoping to find a fix for #21766 as well, on all platforms. Yes, it works for me on Linux with a custom build. And your patch in the attachment makes the difference between a working and broken download (all other things are equal). And, probably of equal importance, it stops the "http channel Listener OnDataAvailable contract violation" message in the console as well. So, I am slightly optimistic for this ticket... I am doing some nightlies right now for better testing, having your fix on top of `tor-browser-52.1.0esr-7.0-2-build1`. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21886#comment:23> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs