#22112: Replace torperf.csv with onionperf.csv -------------------------------------+------------------------------ Reporter: karsten | Owner: metrics-team Type: enhancement | Status: merge_ready Priority: Medium | Milestone: Component: Metrics/Metrics website | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------+------------------------------ Changes (by iwakeh):
* status: needs_review => merge_ready Comment: Replying to [comment:3 karsten]: >[snip] > Well, I'm not a big fan of how we used string constants there, because they give a false sense of code robustness by protecting against typos, but they cannot be used in prepared statements and also don't provide any type safety. And at least during development I ran much more often into the latter two issues than into typos. But maybe you're right and string constants are better than nothing. Changed. Thanks! It is mostly the 'better than nothing' reason and also more readability (using the same constant is clearly saying these strings mean the same). Of course all the improvements for db access will need their own little project. > > Please find [https://gitweb.torproject.org/karsten/metrics- web.git/log/?h=task-22112 my task-22112 branch] with the fixes. What do you think? Ready to remove the beta label and call this done? :) Yep, ready for non-beta. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22112#comment:4> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs