#1922: torrc.d-style configuration directories -------------------------------------------------+------------------------- Reporter: aa138346 | Owner: | Jigsaw52 Type: enhancement | Status: | needs_review Priority: Low | Milestone: Tor: | 0.3.2.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-client, intro, | Actual Points: tor-03-unspecified-201612 | Parent ID: | Points: medium Reviewer: | Sponsor: -------------------------------------------------+------------------------- Changes (by Jigsaw52):
* status: needs_revision => needs_review Comment: I've fixed most of the issues. Comments below: 1. I find my version easier to read but I changed it back for consistency sake since this pattern is used on other places too. 2. Done. 3. and 4. I agree with the suggestion to expose the two APIs for config_get_lines and I implemented it. config_get_lines_include processes includes while config_get_lines is the same as before. 5. Done. 6. Done. 7. I don't understand this one. I sort the list right after the calling tor_listdir(). 8. I do not like the paths ending in /* because it might mislead users into thinking the * wildcard will work for any pattern. However, I added tests to make sure ending the path with PATH_SEPARATOR is supported as it is any easy way to tell a directory and a regular file apart. I left automatic detection of file/directory. 9. Added support for quoted paths. Added tests for it too. I've merged with the current master and squashed all my changes here: https://github.com/Jigsaw52/tor/tree/torrc-dir-fix-1922_squashed -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1922#comment:78> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs