#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-------------------------------------------------+-------------------------
Reporter: gk | Owner: mcs
Type: defect | Status:
| needs_review
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Critical | Resolution:
Keywords: ff52-esr, tbb-e10s, tbb-crash, | Actual Points:
TorBrowserTeam201705R, tbb-7.0-must |
Parent ID: | Points:
Reviewer: | Sponsor:
| Sponsor4
-------------------------------------------------+-------------------------
Comment (by mcs):
Replying to [comment:37 arthuredelstein]:
> I built and manually tested on Windows (with both large files and very
small files) and it works! I wasn't able to reproduce the problem seen in
OSX in comment:36.
Thanks a lot for testing on Windows.
> In the patch, I notice there are a few calls in
`nsExternalAppHandler::OnStartRequest` where you get a return value,
assign it to `rv` and ignore it. I wonder what should be done if
`Suspend()` or `ShouldCancel()` or `Resume()` returns an error code? Or
potentially the `Unused << Function();` construct could be used instead:
> https://dxr.mozilla.org/mozilla-esr52/source/mfbt/Unused.h
Kathy and I intended to ignore failures when calling `Suspend()` and
`Resume()`. We had the `rv =` there to make debugging easier, so we will
try using `Unused <<`.
I think we should add restore the `NS_ENSURE_SUCCESS(rv, rv);` after the
call to `shouldCance()` though; that was removed by mistake.
Georg, do you have any comments on the patch?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21766#comment:38>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
