#22141: Deprecate `DescriptorFile` and add relevant information to `Descriptor` ---------------------------------+----------------------------------- Reporter: karsten | Owner: karsten Type: enhancement | Status: needs_review Priority: Medium | Milestone: metrics-lib 1.9.0 Component: Metrics/metrics-lib | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: ---------------------------------+-----------------------------------
Comment (by iwakeh): Replying to [comment:24 karsten]: > Where in the JavaDocs would you state that there won't be any useful content to expect? In `Descriptor` or in overridden methods in `UnparseableDescriptor`? Only in the overridden methods. Actually, it might be better to throw the "not available" runtime exceptions in order to avoid future bug-hunts when the getAnnotations, getUnrecognizedLines methods get called on an Unp.Descr. The exceptions would make the code fail early and clearly point to the problem. > > By the way, I'm still busy testing the changed branch in applications. One issue I ran into is that I didn't find an easy way to use the new `readDescriptors()` method in the CollecTor sync part. Would you mind replacing that code there, just to see that the new interface works for it, too? I'll take a look. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22141#comment:25> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs