#22831: Merge Snowflake for mac --------------------------------------------+------------------------------ Reporter: dcf | Owner: tbb-team Type: task | Status: | needs_revision Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: snowflake TorBrowserTeam201707 | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: --------------------------------------------+------------------------------ Changes (by gk):
* keywords: snowflake TorBrowserTeam201707R => snowflake TorBrowserTeam201707 * status: needs_review => needs_revision Comment: Looks good. The `needs_revision` is mainly for the following nits: s/clang 0.3.8/clang 3.8.0/ https://github.com/golang/go/issues/9206#issuecomment-310476743 is used for both path and timestamp issue. It seems for the latter we want a different URL? s/The linux descriptor builds its own copy of gn here/The linux descriptor builds its own copy of gn/ s/the gn so build/the gn so built/ --- One thing I was wondering is whether it would be more beneficial to split up the big webrtc patch into smaller ones. It might make it easier to follow the upstreaming efforts that way giving a clear impression on how many patches still need to get upstreamed and making patches easier to write once one or another of those patches is not needed anymore. I don't feel strongly about that, though. If you want to leave that as-is, fine with me. I have trouble to understand why `faketime` is needed now when building `go` given that we use `go` built without it for `obfs4proxy` and `meek` without any issues. "including those that arise here while compiling the Go runtime itself" should hold for the latter PTs as well, yet we don't need `faketime` in those cases. What is different between the `snowflake- client` and, say, the `obfs4proxy` case so that we need `faketime` for building `go` itself now? Are the problematic .o files plainly missing in `obfs4proxy`'s and `meek`s case? Or... -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22831#comment:3> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs