#22979: prop224: Add an introduction point onion key in the descriptor ---------------------------------------+----------------------------------- Reporter: dgoulet | Owner: dgoulet Type: enhancement | Status: needs_review Priority: Medium | Milestone: Tor: | 0.3.2.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-hs, prop224, tor-spec | Actual Points: Parent ID: #21888 | Points: 0.1 Reviewer: asn | Sponsor: SponsorR-must ---------------------------------------+-----------------------------------
Comment (by asn): Replying to [comment:5 dgoulet]: > Branch: `ticket22979_032_01` > > It's not that big so let me know if an Oniongit would be needed. LGTM, but two quick questions: a) I assume that `ip->onion_key` will be initialized by the service code that is not yet included in the branch. So it's OK that it's not really filled with anything on the service-side, right? b) Do we really want to `goto err` if we don't recognize the key type when decoding descriptor? Doesn't that influence our forward-compatibility that the key type field was supposed to be helping? -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22979#comment:6> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs